Unsound call of set_var
#1664
Merged
Unsound call of set_var
#1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sftse
force-pushed
the
unsound-ref-to-mut-ref
branch
2 times, most recently
from
af7d167 to
c49b987
Compare
Merged
Manishearth
reviewed
Oct 23, 2024
There was a problem hiding this comment.
not really convinced this abstraction pulls its weight compared to the approach in #1651 , it doesn't really internalize any safety invariants
|
I didn't know how sensitive miri was to detecting the UB, so an own module and test seemed appropriate. I agree and have removed it, deferring to #1651 to resolve this issue. |
sftse
force-pushed
the
unsound-ref-to-mut-ref
branch
from
c49b987 to
3f0adc9
Compare
|
Thanks a lot for opening the PR and contributing either ways! 🤗 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Oct 24, 2024
…unsafe It is generally not safe to set env variables. The correct way to set a config value that needs to be overridden is to hold a copy internal to the library and only read from the environment.
sftse
force-pushed
the
unsound-ref-to-mut-ref
branch
from
3f0adc9 to
5e25a91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been multiple attempts to communicate that the pattern
&mut *(&T as *const T as *mut T)is not sound, as in #1485 .This is the most straightforward modification of the code that passesSee #1651 for the fix.cargo miri.To detect the unsoundness, the parallelism must be turned off under miri, otherwise it falls over because of some unrelated issue in
crossbeam-epoch:There
are two soundness issuesis one soundness issue fix and one code cleanup in this PR.The
firstsoundness issueis transforming & to &mut, the secondis hidden by the fact that std until recently had a safeenv::set_varfunction. This was a breaking change and is as of now an unsafe function to call.Lastly, some elided lifetimes were making it quite hard to see whether the use of
RefMutContaineras mentioned in #1612 was sound. It does not seem to be unsound.